Talk:Small FFmpeg Tasks

should we link or quote some ffmpeg patch rules? e.g. tabs are forbidden, use diff -u or svn diff or (insert git command). it seems like this is a common mistake for SoC students. -- Compn 10:53, 29 March 2008 (EDT)

Well the mailing list page has a link to the MPlayer patch guidelines, but it's missing a few things such as:

• No trailing whitespace
• Must not break the regression tests
• If it does change the regression tests, you must update regression.ref
• Must check bounds on all input and must not allow overflow or other out-of-bounds condition
• Use meaningful variable names
• Globals/externs should have ff_ prefix to avoid naming conflicts
• Doxygen comments
• No breaking C standards (eg using underscore prefixes)
• Keep { } tidy
• No code duplication
• Workarounds for compiler bugs (eg MSVC) must not break other platforms

Anything else? -- Mkhodor 13:18, 31 March 2008 (EDT)

Delphine CIN?

But we already have it in FFmpeg - look at libavcodec/dsicinav.c and libavformat/dsicin.c --Kostya 01:43, 31 March 2008 (EDT)

Awesome. See, that's what this collaborative Wiki model is good for-- keeping me honest. :-) I'll get a test in FATE soon. --Multimedia Mike 02:05, 31 March 2008 (EDT)